On Tue, May 10, 2022 at 11:33:19AM +0200, Andy Shevchenko wrote: > On Tue, May 10, 2022 at 8:44 AM Muhammad Usama Anjum > <usama.anjum@xxxxxxxxxxxxx> wrote: > > > > From: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx> > > > > The x86 Chromebooks have the ChromeOS ACPI device. This driver attaches > > to the ChromeOS ACPI device and exports the values reported by ACPI in a > > sysfs directory. This data isn't present in ACPI tables when read > > through ACPI tools, hence a driver is needed to do it. The driver gets > > data from firmware using the ACPI component of the kernel. The ACPI values > > are presented in string form (numbers as decimal values) or binary > > blobs, and can be accessed as the contents of the appropriate read only > > files in the standard ACPI device's sysfs directory tree. This data is > > consumed by the ChromeOS user space. > > > Cc: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> > > Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > > Cc: Hans de Goede <hdegoede@xxxxxxxxxx> > > You can use --cc parameter to `git send-email` instead of putting > these lines in the commit message. > > ... > > > +#define DEV_ATTR(_var, _name) \ > > + static struct device_attribute dev_attr_##_var = \ > > + __ATTR(_name, 0444, chromeos_first_level_attr_show, NULL); > > + > > Why not ATTR_RO()? Try it and see, that will not work here. thanks, greg k-h
