On Thu, Apr 28 2022 at 08:38, Tony Luck wrote: > +/* > + * Load ifs image. Before loading ifs module, the ifs image must be located > + * in /lib/firmware/intel/ifs and named as {family/model/stepping}.{testname}. > + */ > +void ifs_load_firmware(struct device *dev) > +{ > + const struct firmware *fw; > + char scan_path[32]; > + int ret; > + > + snprintf(scan_path, sizeof(scan_path), "intel/ifs/%02x-%02x-%02x.scan", > + boot_cpu_data.x86, boot_cpu_data.x86_model, boot_cpu_data.x86_stepping); > + > + ret = request_firmware_direct(&fw, scan_path, dev); > + if (ret) { > + dev_err(dev, "ifs file %s load failed\n", scan_path); > + return; Why is this not returning an error to the caller? Thanks, tglx