hello all, any reason this patch failed to get noticed? I have lots of users running my upstream coreboot builds which are affected by this issue thanks, Matt On Tue, Jan 11, 2022 at 9:36 AM Matt DeVillier <matt.devillier@xxxxxxxxx> wrote: > > Since 2017, Chrome devices running custom coreboot firmware default > to using 'Google' as the system vendor, vs 'GOOGLE' for older > devices. Add a DMI match to cover this case as well. > > Test: cros_ec_lpc successfully attaches to Chromebox running > custom coreboot firmware with bios vendor 'coreboot' and > system vendor 'Google'. > > Signed-off-by: Matt DeVillier <matt.devillier@xxxxxxxxx> > --- > drivers/platform/chrome/cros_ec_lpc.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/platform/chrome/cros_ec_lpc.c > b/drivers/platform/chrome/cros_ec_lpc.c > index d6306d2a096f..ae366a34bb63 100644 > --- a/drivers/platform/chrome/cros_ec_lpc.c > +++ b/drivers/platform/chrome/cros_ec_lpc.c > @@ -465,13 +465,19 @@ static const struct dmi_system_id > cros_ec_lpc_dmi_table[] __initconst = { > * If the box is running custom coreboot firmware then the > * DMI BIOS version string will not be matched by "Google_", > * but the system vendor string will still be matched by > - * "GOOGLE". > + * "GOOGLE" or "Google". > */ > .matches = { > DMI_MATCH(DMI_BIOS_VENDOR, "coreboot"), > DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"), > }, > }, > + { > + .matches = { > + DMI_MATCH(DMI_BIOS_VENDOR, "coreboot"), > + DMI_MATCH(DMI_SYS_VENDOR, "Google"), > + }, > + }, > { > /* x86-link, the Chromebook Pixel. */ > .matches = { > -- > 2.32.0