Re: [PATCH] platform/x86: dell-laptop: Add quirk entry for Latitude 7520

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



+ Dell.Client.Kernel@xxxxxxxx : please look at this issue below

On Tuesday 26 April 2022 14:08:27 gabriele.mzt@xxxxxxxxx wrote:
> From: Gabriele Mazzotta <gabriele.mzt@xxxxxxxxx>
> 
> The Latitude 7520 supports AC timeouts, but it has no KBD_LED_AC_TOKEN
> and so changes to stop_timeout appear to have no effect if the laptop
> is plugged in.
> 
> Signed-off-by: Gabriele Mazzotta <gabriele.mzt@xxxxxxxxx>
> ---
> As per the discussion here https://github.com/dell/libsmbios/issues/48,
> this is really a BIOS bug. My Latitude 7520 has the latest BIOS
> update installed, which was released just few months ago, but the
> issue is still there.

In that ticket is written that issue was already fixed and discussion
closed.

If it is not truth then please open and report a new ticket on github.

And ideally report also this issue directly to Dell BIOS team per
https://github.com/dell/libsmbios/issues/48#issuecomment-391328501
because as written that this is the right way for fixing the issue,
rather than kernel patch.

> ---
>  drivers/platform/x86/dell/dell-laptop.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/drivers/platform/x86/dell/dell-laptop.c b/drivers/platform/x86/dell/dell-laptop.c
> index 8230e7a68a5e..1321687d923e 100644
> --- a/drivers/platform/x86/dell/dell-laptop.c
> +++ b/drivers/platform/x86/dell/dell-laptop.c
> @@ -80,6 +80,10 @@ static struct quirk_entry quirk_dell_inspiron_1012 = {
>  	.kbd_led_not_present = true,
>  };
>  
> +static struct quirk_entry quirk_dell_latitude_7520 = {
> +	.kbd_missing_ac_tag = true,
> +};
> +
>  static struct platform_driver platform_driver = {
>  	.driver = {
>  		.name = "dell-laptop",
> @@ -336,6 +340,15 @@ static const struct dmi_system_id dell_quirks[] __initconst = {
>  		},
>  		.driver_data = &quirk_dell_inspiron_1012,
>  	},
> +	{
> +		.callback = dmi_matched,
> +		.ident = "Dell Latitude 7520",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Latitude 7520"),
> +		},
> +		.driver_data = &quirk_dell_latitude_7520,
> +	},
>  	{ }
>  };
>  
> -- 
> 2.36.0
> 

In any case:

Acked-by: Pali Rohár <pali@xxxxxxxxxx>

But I hope that Dell fixes this issue in their BIOS.



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux