On Tue, Apr 19, 2022 at 07:20:54PM +0200, Greg KH wrote: > > +/* > > + * Note there is no need for a ->remove() call back. There isn't an > > + * "unload" operation to remove the scan binary from the BIOS reserved > > + * area. Also ".dev_groups" removal order will guarantee that any in > > + * flight tests have completed. > > + */ > > So you are ok with the warning the kernel gives you when you unload the > driver? That feels wrong :( What warning? # dmesg | tail -5 [ 38.084165] virbr0: port 1(virbr0-nic) entered listening state [ 38.149621] virbr0: port 1(virbr0-nic) entered disabled state [ 38.582054] broken atomic modeset userspace detected, disabling atomic [ 43.703321] igc 0000:01:00.0 enp1s0: NIC Link is Up 2500 Mbps Full Duplex, Flow Control: RX [ 43.703470] IPv6: ADDRCONF(NETDEV_CHANGE): enp1s0: link becomes ready # modprobe intel_ifs # ls /sys/devices/platform/intel_ifs.0/ details driver_override modalias reload status uevent driver image_version power run_test subsystem # rmmod intel_ifs # dmesg | tail -5 [ 38.084165] virbr0: port 1(virbr0-nic) entered listening state [ 38.149621] virbr0: port 1(virbr0-nic) entered disabled state [ 38.582054] broken atomic modeset userspace detected, disabling atomic [ 43.703321] igc 0000:01:00.0 enp1s0: NIC Link is Up 2500 Mbps Full Duplex, Flow Control: RX [ 43.703470] IPv6: ADDRCONF(NETDEV_CHANGE): enp1s0: link becomes ready # -Tony
