On 4/19/22 07:19, Sathyanarayanan Kuppuswamy wrote: > On 4/19/22 7:13 AM, Dave Hansen wrote: >>> >From this perspective, I am not sure what's the value of having a >>> dedicated >>> INTEL_TDX_ATTESTATION Kconfig. The attestation support code should >>> be turned on >>> unconditionally when CONFIG_INTEL_TDX_GUEST is on. The code can also >>> be just >>> under arch/x86/coco/tdx/ I guess? >> How much code are we talking about? What's the difference in the size >> of the binaries with this compiled in? > > Current driver size is ~300 lines. It adds ~500 bytes to the kernel > binary if it is built-in. That doesn't sound like good use of a Kconfig option to me. Just explain in the cover letter: Any distribution enabling TDX is also expected to need attestation. The compiled size is quite small (500 bytes).
