On 4/19/22 1:13 AM, Borislav Petkov wrote:
On Tue, Apr 19, 2022 at 07:47:33PM +1200, Kai Huang wrote:
From this perspective, I am not sure what's the value of having a dedicated
INTEL_TDX_ATTESTATION Kconfig. The attestation support code should be turned on
unconditionally when CONFIG_INTEL_TDX_GUEST is on. The code can also be just
under arch/x86/coco/tdx/ I guess?
But I'll leave this to maintainers.
Similar story with the unaccepted memory gunk. If it is not going to
be used outside of encrypted guests, why are we polluting our already
insanely humongous Kconfig space with more symbols?
Make sense. We can just go with CONFIG_INTEL_TDX_ATTESTATION.
Boris, this is a simple platform driver which adds IOCTL interfaces to
allow user space to get TDREPORT and TDQuote support.
So, would prefer to leave in platform/x86 or move it to arch/x86/coco/tdx/ ?
--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer
