[Public] > -----Original Message----- > From: Jorge Lopez <jorgealtxwork@xxxxxxxxx> > Sent: Thursday, April 7, 2022 08:45 > To: Limonciello, Mario <Mario.Limonciello@xxxxxxx> > Cc: Hans de Goede <hdegoede@xxxxxxxxxx>; platform-driver- > x86@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v1 5/6] Sure Admin Security Feature > > Hans, Mario, > > The code links make references to code that implements the new > interfaces but there’s > still code in the kernel that uses the old ones. I do agree we should > be forward looking > and want to be good participants in the kernel development, but can’t > let our immediate > business needs be impacted with opportunities to enhance the driver to > take advantage > of the latest kernel features. > Keep in mind that from an upstream kernel perspective this driver is "new". There is no requirements from the upstream perspective to keep your old interfaces in place from when it was out of tree. Requirements like this start when the driver is in tree. https://www.kernel.org/doc/html/latest/admin-guide/abi-stable.html > Rewriting those security features will impact customer business > datelines requiring > HP to provide private releases as the kernel version changes. The > requested changes > will impact products in the market and HP ability to help customers to > migrate to Linux > from Windows products. > > It is because of the immediate business needs, avoiding impacting our > customers/products, > and rewriting enhancements to the driver that I need to propose an > interim solution. Right, get it upstream and it's less work, of course 😊 > > My proposal is to introduce a read/write value accessible in the user > space to control how > the driver reports and handles BIOS settings and values. The new > configuration features > will be gradually disabled as they are converted to use the standardized API. > It is like the configuration flag used to overcome the tablet detection > problem > introduced in the past. The changes solely affect the HP WMI driver. > This option will help us > move forward for this release and give us time to make the necessary > changes to both > the driver and support applications. > > Please let me know if this is a viable interim solution. > > If it is not possible, I need to ask where the actual written > requirement is found so I can > include them in the business justification for changes and release > delays to management. >
