Hi, On 3/22/22 07:18, Jiapeng Chong wrote: > Eliminate the follow smatch warnings: > > drivers/platform/x86/samsung-laptop.c:1124 kbd_led_set() warn: unsigned > 'value' is never less than zero. > > Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx> > Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/samsung-laptop.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c > index c1d9ed9b7b67..19f6b456234f 100644 > --- a/drivers/platform/x86/samsung-laptop.c > +++ b/drivers/platform/x86/samsung-laptop.c > @@ -1121,8 +1121,6 @@ static void kbd_led_set(struct led_classdev *led_cdev, > > if (value > samsung->kbd_led.max_brightness) > value = samsung->kbd_led.max_brightness; > - else if (value < 0) > - value = 0; > > samsung->kbd_led_wk = value; > queue_work(samsung->led_workqueue, &samsung->kbd_led_work);
