[kbuild] Re: [PATCH v4 1/3] ACPI / x86: Add support for LPS0 callback handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mario,

url:    https://github.com/0day-ci/linux/commits/Mario-Limonciello/ACPI-x86-Add-support-for-LPS0-callback-handler/20220317-053103 
base:    a32cd981a6da2373c093d471ee4405a915e217d5
config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20220317/202203171657.uF7h6TEG-lkp@xxxxxxxxx/config )
compiler: gcc-9 (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

smatch warnings:
drivers/acpi/x86/s2idle.c:478 acpi_s2idle_prepare_late() error: we previously assumed 'handler' could be null (see line 479)

vim +/handler +478 drivers/acpi/x86/s2idle.c

fa209644a7124b Mario Limonciello  2021-09-01  474  		acpi_sleep_run_lps0_dsm(ACPI_LPS0_MS_ENTRY,
fa209644a7124b Mario Limonciello  2021-09-01  475  				lps0_dsm_func_mask_microsoft, lps0_dsm_guid_microsoft);
fef98671194be0 Rafael J. Wysocki  2020-12-17  476  	}
4be2feac72a3ad Mario Limonciello  2022-03-16  477  
4be2feac72a3ad Mario Limonciello  2022-03-16 @478  	list_for_each_entry(handler, &lps0_s2idle_devops_head, list_node) {
4be2feac72a3ad Mario Limonciello  2022-03-16 @479  		if (handler)
4be2feac72a3ad Mario Limonciello  2022-03-16  480  			handler->prepare();

The list iterator can never be NULL so there is no need to check.

4be2feac72a3ad Mario Limonciello  2022-03-16  481  	}
4be2feac72a3ad Mario Limonciello  2022-03-16  482  
fef98671194be0 Rafael J. Wysocki  2020-12-17  483  	return 0;
fef98671194be0 Rafael J. Wysocki  2020-12-17  484  }

---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx 
_______________________________________________
kbuild mailing list -- kbuild@xxxxxxxxxxxx
To unsubscribe send an email to kbuild-leave@xxxxxxxxxxxx




[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux