Thanks Hans,
I hadn't realised that was the case - appreciate the fix
Mark
On 2022-03-09 12:05, Hans de Goede wrote:
> test_bit can only be used on longs not on ints, fix this.
>
> Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> ---
> p.s. Mark, the need for the (void *) case in the code this replaces
> should have been a hint that something was not right; and I should
> have spotted that during review...
> ---
> drivers/platform/x86/thinkpad_acpi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index 7016c7fc3440..c476a78599d6 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -10399,7 +10399,7 @@ static int tpacpi_dytc_profile_init(struct ibm_init_struct *iibm)
> if (err)
> return err;
>
> - if (test_bit(DYTC_FC_MMC, (void *)&output)) { /* MMC MODE */
> + if (output & BIT(DYTC_FC_MMC)) { /* MMC MODE */
> dytc_profile_available = DYTC_FUNCMODE_MMC;
>
> /*
> @@ -10412,7 +10412,7 @@ static int tpacpi_dytc_profile_init(struct ibm_init_struct *iibm)
> if (!err && ((output & DYTC_ERR_MASK) == DYTC_ERR_SUCCESS))
> dytc_mmc_get_available = true;
> }
> - } else if (test_bit(DYTC_FC_PSC, (void *)&output)) { /*PSC MODE */
> + } else if (output & BIT(DYTC_FC_PSC)) { /* PSC MODE */
> dytc_profile_available = DYTC_FUNCMODE_PSC;
> } else {
> dbg_printk(TPACPI_DBG_INIT, "No DYTC support available\n");
