Thanks Hans On 2022-03-02 09:47, Hans de Goede wrote: > Hi, > > On 2/25/22 19:25, Mark Pearson wrote: >> The Lenovo AMD platforms use PSC mode for providing platform >> profile support. >> >> Detect if PSC mode is available and add support for setting the >> different profile modes appropriately. >> >> Note - if both MMC mode and PSC mode are available then MMC mode >> will be used in preference. >> >> Tested on T14 G1 AMD and T14s G2 AMD. >> >> Signed-off-by: Mark Pearson <markpearson@xxxxxxxxxx> > > Thank you for your patch, I've applied this patch to my review-hans > branch: > https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans>> > Note it will show up in my review-hans branch once I've pushed my > local branch there, which might take a while. > > Once I've run some tests on this branch the patches there will be > added to the platform-drivers-x86/for-next branch and eventually > will be included in the pdx86 pull-request to Linus for the next > merge-window. > > Regards, > > Hans > Awesome - thank you! > > > p.s. > > One small thing which I noticed which could be improved is to > move the 2 convert_profile_to_dytc() calls in dytc_profile_set() > to a single call at the top of the function (before taking the > lock even) to avoid code duplication between the DYTC_FUNCMODE_MMC > vs DYTC_FUNCMODE_PSC paths. > > I didn't want to block merging the patch on this, if you can > do a follow up patch with that as cleanup that would be great. > ack - that makes sense. Will do. Mark
