Hi, On 2/12/22 13:59, Mateusz Jończyk wrote: > The declaration > EXPORT_SYMBOL(dcdbas_smi_request); > was placed after smi_request_store(), which made a false impression that > dcdbas_smi_request() was not exported. > > Signed-off-by: Mateusz Jończyk <mat.jonczyk@xxxxx> > Cc: Stuart Hayes <stuart.w.hayes@xxxxxxxxx> > Cc: Hans de Goede <hdegoede@xxxxxxxxxx> > Cc: Mark Gross <markgross@xxxxxxxxxx> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/dell/dcdbas.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/dell/dcdbas.c b/drivers/platform/x86/dell/dcdbas.c > index 5e63d6225048..db3633fafbd5 100644 > --- a/drivers/platform/x86/dell/dcdbas.c > +++ b/drivers/platform/x86/dell/dcdbas.c > @@ -284,6 +284,7 @@ int dcdbas_smi_request(struct smi_cmd *smi_cmd) > > return ret; > } > +EXPORT_SYMBOL(dcdbas_smi_request); > > /** > * smi_request_store: > @@ -351,7 +352,6 @@ static ssize_t smi_request_store(struct device *dev, > mutex_unlock(&smi_data_lock); > return ret; > } > -EXPORT_SYMBOL(dcdbas_smi_request); > > /** > * host_control_smi: generate host control SMI >
