Hi, On 2/4/22 01:03, Srinivas Pandruvada wrote: > The uncore frequency scaling is getting used by more customers to either > have a deterministic performance or control power consumption. > The uncore frequency scaling depends on non architecture MSRs, format of > those MSR can be different on different generations of CPUs. > This series prepares for easy addition of new HW interface. > > There are no functional changes done except adding a new addition to > read uncore frequency. > > - The first patch creates a separate folder for uncore-freq. > - The second patch uses sysfs groups to create attributes. > - The third patch adds capability to read current uncore frequency. > - The fourth patch splits common and enumeration part. The enumeration > part will be specific to each HW interface. > > Srinivas Pandruvada (4): > platform/x86/intel/uncore-freq: Move to uncore-frequency folder > platform/x86/intel/uncore-freq: Use sysfs API to create attributes > platform/x86/intel/uncore-freq: Display uncore current frequency > platform/x86/intel-uncore-freq: Split common and enumeration part Thank you for your patch-series, I've applied the series to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Note I've squashed a small MAINTAINERS change in to patch 1/4 so that the maintainers entry now points to the new sub-dir. Regards, Hans > > drivers/platform/x86/intel/Kconfig | 14 +- > drivers/platform/x86/intel/Makefile | 4 +- > drivers/platform/x86/intel/uncore-frequency.c | 452 ------------------ > .../x86/intel/uncore-frequency/Kconfig | 21 + > .../x86/intel/uncore-frequency/Makefile | 9 + > .../uncore-frequency-common.c | 252 ++++++++++ > .../uncore-frequency-common.h | 62 +++ > .../intel/uncore-frequency/uncore-frequency.c | 272 +++++++++++ > 8 files changed, 620 insertions(+), 466 deletions(-) > delete mode 100644 drivers/platform/x86/intel/uncore-frequency.c > create mode 100644 drivers/platform/x86/intel/uncore-frequency/Kconfig > create mode 100644 drivers/platform/x86/intel/uncore-frequency/Makefile > create mode 100644 drivers/platform/x86/intel/uncore-frequency/uncore-frequency-common.c > create mode 100644 drivers/platform/x86/intel/uncore-frequency/uncore-frequency-common.h > create mode 100644 drivers/platform/x86/intel/uncore-frequency/uncore-frequency.c >