On Tue, 2022-02-01 at 09:49 +0100, Greg KH wrote: > On Mon, Jan 31, 2022 at 07:04:22PM -0800, David E. Box wrote: > > +static struct bin_attribute bin_attr_provision_akc; > > +static struct bin_attribute bin_attr_provision_cap; > > <snip> > > > +static BIN_ATTR_WO(provision_akc, SDSI_SIZE_WRITE_MSG); > > You the structure twice, why? Will drop. There's no longer a reference to these attributes before they're defined. David >