On Fri, Jan 28, 2022 at 11:17:46AM -0600, Brijesh Singh wrote: > diff --git a/arch/x86/boot/compressed/efi.c b/arch/x86/boot/compressed/efi.c > index daa73efdc7a5..bf99768cd229 100644 > --- a/arch/x86/boot/compressed/efi.c > +++ b/arch/x86/boot/compressed/efi.c > @@ -48,3 +48,32 @@ enum efi_type efi_get_type(struct boot_params *boot_params) > > return et; > } > + > +/* /** kernel-doc comment pls. > + * efi_get_system_table - Given boot_params, retrieve the physical address of > + * EFI system table. > + * > + * @boot_params: pointer to boot_params > + * > + * Return: EFI system table address on success. On error, return 0. > + */ > +unsigned long efi_get_system_table(struct boot_params *boot_params) ... *bp) - as before. Please go through all those functions taking in struct boot_params ptr. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette