Hi, On 1/11/22 12:31, Andy Shevchenko wrote: > On Tue, Jan 11, 2022 at 11:56:32AM +0100, Hans de Goede wrote: >> The gpio-tps68470 driver binds to a tps68470-gpio platform-device which >> itself gets instantiated by a special MFD driver from >> drivers/platform/x86/intel/int3472/tps68470.c >> >> This MFD driver itself can be built as a module, so it makes no sense to >> force the gpio-tps68470 driver to always be built-in. >> >> Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> >> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > >> Changes in v2: >> - Fix some spelling errors in the commit msg >> - Remove blank line between tps68470_gpio_driver decleration and >> module_platform_driver(tps68470_gpio_driver) > > It used to be 2 patches in the series, are you going to send another one > separately? Ah right, I forgot this was a series. The other one had no review comments, so v1 is still valid, you can find it here: https://lore.kernel.org/linux-gpio/20211225120026.95268-2-hdegoede@xxxxxxxxxx/ Regards, Hans