On 12/6/21 6:33 PM, Hans de Goede wrote: > The CHT_WC_VBUS_GPIO_CTLO GPIO actually driving an external 5V Vboost > converter for Vbus depends on the board on which the Cherry Trail - > Whiskey Cove PMIC is actually used. > > Since the information about the exact PMIC setup is necessary in other > places too, struct intel_soc_pmic now has a new cht_wc_model field > indicating the board model. > > Only poke the CHT_WC_VBUS_GPIO_CTLO GPIO if this new field is set to > INTEL_CHT_WC_GPD_WIN_POCKET, which indicates the Type-C (with PD and > DP-altmode) setup used on the GPD pocket and GPD win; and on which > this GPIO actually controls an external 5V Vboost converter. > > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > --- > Changes in v3: > - Use the new cht_wc_model intel_soc_pmic field which replaces the > intel_cht_wc_get_model() helper and adjust the commit msg to match > --- > drivers/extcon/extcon-intel-cht-wc.c | 35 +++++++++++++++++----------- > 1 file changed, 21 insertions(+), 14 deletions(-) [snip] Acked-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx> -- Best Regards, Chanwoo Choi Samsung Electronics