On Wed, 2021-12-08 at 17:22 +0100, Greg KH wrote: > On Tue, Dec 07, 2021 at 05:50:12PM -0800, David E. Box wrote: > > +static struct pci_driver intel_vsec_pci_driver = { > > + .name = "intel_vsec", > > + .id_table = intel_vsec_pci_ids, > > + .probe = intel_vsec_pci_probe, > > +}; > > So when the PCI device is removed from the system you leak resources and > have dangling devices? No. > > Why no PCI remove driver callback? After probe all resources are device managed. There's nothing to explicitly clean up. When the PCI device is removed, all aux devices are automatically removed. This is the case for the SDSi driver as well. David > > thanks, > > greg k-h