On Wed, Dec 08, 2021 at 08:43:53AM +0000, Lee Jones wrote: > On Wed, 08 Dec 2021, Greg KH wrote: > > > On Wed, Dec 08, 2021 at 09:03:16AM +0200, Leon Romanovsky wrote: > > > On Tue, Dec 07, 2021 at 09:14:44AM -0800, David E. Box wrote: > > > > Adds get/set driver data helpers for auxiliary devices. > > > > > > > > Signed-off-by: David E. Box <david.e.box@xxxxxxxxxxxxxxx> > > > > Reviewed-by: Mark Gross <markgross@xxxxxxxxxx> > > > > --- > > > > V2 > > > > - No changes > > > > > > > > include/linux/auxiliary_bus.h | 10 ++++++++++ > > > > 1 file changed, 10 insertions(+) > > > > > > I would really like to see an explanation why such obfuscation is really > > > needed. dev_*_drvdata() is a standard way to access driver data. > > I wouldn't call it obfuscation, but it does looks like abstraction for > the sake of abstraction, which I usually push back on. What are the > technical benefits over using the dev_*() variant? You can see it in Greg's answer, there is no technical benefits in any variant. It is simple copy/paste pattern from other buses. Maybe it is not clear from my response, I don't care if this patch is going to be applied or not, but I would like to hear someone explains to me what are the benefits of such one liners. Thanks
