On 2021-11-24 17:28+0100, Hans de Goede wrote: > On 11/24/21 16:53, Thomas Weißschuh wrote: > > Hi, > > > > On 2021-11-23 22:05+0100, Hans de Goede wrote: > >> There have been various bugs / forum threads about allowing control of > >> the LED in the ThinkPad logo on the lid of various models. > >> > >> This seems to be something which users want to control and there really > >> is no reason to require setting CONFIG_THINKPAD_ACPI_UNSAFE_LEDS for this. > >> > >> The lid-logo-led is LED number 10, so change the name of the 10th led > >> from unknown_led2 to lid_logo_led and add it to the TPACPI_SAFE_LEDS mask. > >> > >> Link: https://www.reddit.com/r/thinkpad/comments/7n8eyu/thinkpad_led_control_under_gnulinux/ > >> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1943318 > >> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > >> --- > >> drivers/platform/x86/thinkpad_acpi.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c > >> index 49fdf16b2db9..28f0299ecab0 100644 > >> --- a/drivers/platform/x86/thinkpad_acpi.c > >> +++ b/drivers/platform/x86/thinkpad_acpi.c > >> @@ -5661,11 +5661,11 @@ static const char * const tpacpi_led_names[TPACPI_LED_NUMLEDS] = { > >> "tpacpi::standby", > >> "tpacpi::dock_status1", > >> "tpacpi::dock_status2", > >> - "tpacpi::unknown_led2", > >> + "tpacpi::lid_logo_led", > > > > The suffix "_led" looks a bit redundant. Also non of the other LEDs have it. > > Hmm, good point, but without the _led to me it sounds as if it controls > some backlight for the entire logo, where it really is just the dot of the i. lid_logo_dot? Not sure it's worth the bikeshedding :-) Thomas
