Hi, On 11/22/21 11:14, Andy Shevchenko wrote: > On Sun, Nov 21, 2021 at 9:11 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: >> >> Hi All, >> >> Here is a patch-series for the thinkpad_acpi driver starting with one >> important bugfix which fixes a bug introduced by commit 79f960e29cfc >> ("platform/x86: thinkpad_acpi: Convert platform driver to use dev_groups") >> in platform-drivers-x86/for-next which is causing the driver to not load >> at all on many devices. >> >> Followed by a bunch of cleanup patches. > > It's right thing to do > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> Thank you, I've pushed the entire series to my review-hans branch now. Regards, Hans >> Hans de Goede (7): >> platform/x86: thinkpad_acpi: Accept ibm_init_struct.init() returning >> -ENODEV >> platform/x86: thinkpad_acpi: Make *_init() functions return -ENODEV >> instead of 1 >> platform/x86: thinkpad_acpi: Simplify dytc_version handling >> platform/x86: thinkpad_acpi: Cleanup dytc_profile_available >> platform/x86: thinkpad_acpi: Properly indent code in >> tpacpi_dytc_profile_init() >> platform/x86: thinkpad_acpi: Remove "goto err_exit" from hotkey_init() >> platform/x86: thinkpad_acpi: Fix thermal_temp_input_attr sorting >> >> drivers/platform/x86/thinkpad_acpi.c | 221 ++++++++++----------------- >> 1 file changed, 78 insertions(+), 143 deletions(-) >> >> -- >> 2.31.1 >> > >