On Tue, Nov 9, 2021 at 10:11 AM Sachi King <nakato@xxxxxxxxx> wrote: > > The AMD variant of the Surface Laptop report 0 for their OEM platform > revision. The Surface devices that require the surfacepro3_button > driver do not have the _DSM that gets the OEM platform revision. If the > method does not exist, load surfacepro3_button. ... > * Surface Pro 4 and Surface Book 2 / Surface Pro 2017 use the same device > * ID (MSHW0040) for the power/volume buttons. Make sure this is the right > - * device by checking for the _DSM method and OEM Platform Revision. > + * device by checking for the _DSM method and OEM Platform Revision DSM > + * function. Not sure what this change means (not a native speaker). ... > - dev_dbg(&dev->dev, "OEM Platform Revision %llu\n", oem_platform_rev); I think this is useful to have. What about leaving it as is for debugging purposes and just replacing the last test? ... > + // make sure that OEM platform revision DSM call does not exist Please, fix the comment style while at it. -- With Best Regards, Andy Shevchenko
