Re: [PATCH 2/5] Extend pg_data_t to hold information about memory encryption

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/5/21 2:27 PM, Martin Fernandez wrote:
> @@ -869,6 +869,8 @@ typedef struct pglist_data {
>  	unsigned long		min_slab_pages;
>  #endif /* CONFIG_NUMA */
> 
> +	bool crypto_capable;

When adding to a data structure, please take a moment and familiarize
yourself with it.  For instance, would it make sense to have an
'enum pgdat_flags' for this as opposed to a bool?

Or, if you place it up next to the CONFIG_COMPACTION
proactive_compact_trigger, can it share storage?  Placing it next to a
ulong is probably the worst place it can go.



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux