Re: [PATCH v5 00/11] Add support for X86/ACPI camera sensor/PMIC setup with clk and regulator platform data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 2, 2021 at 11:49 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
>
> Here is v5 of my patch-set adding support for camera sensor connected to a
> TPS68470 PMIC on x86/ACPI devices.

No showstoppers observed, FWIW,
Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

> I'm quite happy with how this works now, so from my pov this is the final
> version of the device-instantiation deferral code / approach.
>
> ###
>
> The clk and regulator frameworks expect clk/regulator consumer-devices
> to have info about the consumed clks/regulators described in the device's
> fw_node, but on ACPI this info is missing.
>
> This series worksaround this by providing platform_data with the info to
> the TPS68470 clk/regulator MFD cells.
>
> Patches 1 - 2 deal with a probe-ordering problem this introduces,
> since the lookups are only registered when the provider-driver binds,
> trying to get these clks/regulators before then results in a -ENOENT
> error for clks and a dummy regulator for regulators. See the patches
> for more details.
>
> Patch 3 adds a header file which adds tps68470_clk_platform_data and
> tps68470_regulator_platform_data structs. The futher patches depend on
> this new header file.
>
> Patch 4 + 5 add the TPS68470 clk and regulator drivers
>
> Patches 6 - 11 Modify the INT3472 driver which instantiates the MFD cells to
> provide the necessary platform-data.


-- 
With Best Regards,
Andy Shevchenko



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux