Hi,
On 10/30/21 17:42, Tim Crawford wrote:
> Users on darp6 that do not have Open EC firmware have reported crashes
> on boot. Correct the error handling for the input device to fix it.
>
> Managed devices do not need to be explicitly unregistered or freed, as
> this is handled by devres. Drop the call to input_free_device.
>
> Fixes: 0de30fc684b ("platform/x86: system76_acpi: Replace Fn+F2 function for OLED models")
>
> Signed-off-by: Tim Crawford <tcrawford@xxxxxxxxxxxx>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/x86/system76_acpi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/platform/x86/system76_acpi.c b/drivers/platform/x86/system76_acpi.c
> index b3c8178420b1..8b292ee95a14 100644
> --- a/drivers/platform/x86/system76_acpi.c
> +++ b/drivers/platform/x86/system76_acpi.c
> @@ -739,7 +739,6 @@ static int system76_add(struct acpi_device *acpi_dev)
> error:
> kfree(data->ntmp);
> kfree(data->nfan);
> - input_free_device(data->input);
> return err;
> }
>
>
