On Sat, Oct 30, 2021 at 9:28 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > On most X86/ACPI devices there is no devicetree to supply the necessary > init-data. Instead the firmware already fully initializes the bq25890 > charger at boot. > > At support for a new "ti,skip-init" boolean property to support this. > So far this new property is only used on X86/ACPI (non devicetree) devs, > IOW it is not used in actual devicetree files. The devicetree-bindings > maintainers have requested properties like these to not be added to the > devicetree-bindings, so the new property is deliberately not added > to the existing devicetree-bindings. With 'ti,' prefix it can be a potential collision in name space, for internal properties I would rather use 'linux,' one. ... > + init->write_cfg = !device_property_read_bool(bq->dev, "ti,skip-init"); > + if (!init->write_cfg) > + return 0; Why to have double negation here? I would rather expect that you will have direct value in the structure and do a respective check in the functions. -- With Best Regards, Andy Shevchenko
