Hi,
On 10/26/21 19:14, Mario Limonciello wrote:
> If the configuration hasn't specified this parameter the rest of the new
> RTC functionality should just be ignored.
>
> Cc: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
> Suggested-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> Fixes: 59348401ebed ("platform/x86: amd-pmc: Add special handling for timer based S0i3 wakeup")
> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
Thank you for your patch-series, I've applied the series to my
review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> Changes from v1->v2:
> * Hardcode the device instead of #ifdef
>
> drivers/platform/x86/amd-pmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/amd-pmc.c b/drivers/platform/x86/amd-pmc.c
> index 678bf6874c63..b8d77a18e95a 100644
> --- a/drivers/platform/x86/amd-pmc.c
> +++ b/drivers/platform/x86/amd-pmc.c
> @@ -425,7 +425,7 @@ static int amd_pmc_verify_czn_rtc(struct amd_pmc_dev *pdev, u32 *arg)
> if (pdev->major < 64 || (pdev->major == 64 && pdev->minor < 53))
> return 0;
>
> - rtc_device = rtc_class_open(CONFIG_RTC_SYSTOHC_DEVICE);
> + rtc_device = rtc_class_open("rtc0");
> if (!rtc_device)
> return 0;
> rc = rtc_read_alarm(rtc_device, &alarm);
>
