Hi, On 10/6/21 22:21, Tim Crawford wrote: > Sync the in-tree system76_acpi module with changes made to the DKMS > module [1]. This introduces/exposes new functionality implemented in the > open source BIOS and EC firmware for System76 laptops. > > v4: > - Reverted DEV_ATTR macro change to keep custom `name` > - Added attribute groups for kb_led_color > - Set kd_led.groups instead of manually creating/removing the sysfs file > v3: > - Made use of DEV_ATTR macro for kb_led_color > - Used sysfs_emit() instead of sprintf() for kb_led_color > v2: > - Used input_set_capability() instead of setting bits directly in patch 2/3 > - Used sysfs_emit() instead of sprintf() in patch 3/3 > - Made use of device_{add,remove}_groups() in patch 3/3 > > [1]: https://github.com/pop-os/system76-acpi-dkms > > > Jeremy Soller (2): > platform/x86: system76_acpi: Report temperature and fan speed > platform/x86: system76_acpi: Replace Fn+F2 function for OLED models > > Tim Crawford (2): > platform/x86: system76_acpi: Add battery charging thresholds > platform/x86: system76_acpi: Add attribute group for kb_led_color > > drivers/platform/x86/system76_acpi.c | 428 ++++++++++++++++++++++++++- > 1 file changed, 412 insertions(+), 16 deletions(-) Thank you for your patch-series, I've applied the series to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans