https://bugzilla.kernel.org/show_bug.cgi?id=204807 --- Comment #135 from Denis Pauk (pauk.denis@xxxxxxxxx) --- (In reply to Eugene Shalygin from comment #134) > Denis, > > thank you for pulling the new changes! > > Could you explain, please, why did you merge the asus-wmi-sensors and > asus-wmi-ec-sensors drivers? As far as I understand, asus-wmi-sensors can > fetch data from all available sensors, including those provided by EC, but > the WMI methods it relies upon are removed from the new ASUS boards. Both drivers have used same entry point and difference as I see that: old boards return some list of sensors with names, new one always returns zero as count of sensors and requires some hardcoded list of sensors. And list of old and new boards is not intersected. As for me, when we have 30% of similar code better have one driver for both cases. Currently driver has 1126 lines. (I have not calculated real size of shared code so it can be bigger or less.) Do you like to be in MAINTAINERS list? Also good news, no EC also will go in next round of updated patches. https://github.com/electrified/asus-wmi-sensors/issues/78 -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
