On Sun, Oct 03, 2021 at 11:19:49AM +0200, Len Baker wrote: > Platform drivers have the option of having the platform core create and > remove any needed sysfs attribute files. So take advantage of that and > refactor the attributes management to avoid to register them "by hand". > > Also, due to some attributes are optionals, refactor the code and move > the logic inside the "is_visible" callbacks of the attribute_group > structures. > > Suggested-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Signed-off-by: Len Baker <len.baker@xxxxxxx> > --- > drivers/platform/x86/thinkpad_acpi.c | 536 ++++++++++++--------------- > 1 file changed, 236 insertions(+), 300 deletions(-) Nice! At first glance this looks great to me, thanks for doing this. Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
