A randconfig or a user can set/enable DELL_WMI_PRIVACY even when DELL_WMI is not enabled. This leads to a build error in dell-laptop.o: ld: drivers/platform/x86/dell/dell-laptop.o: in function `dell_init': dell-laptop.c:(.init.text+0x719): undefined reference to `dell_privacy_has_mic_mute' Fix this by enclosing the DELL_WMI driver options inside a if DELL_WMI / endif bracket. Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> Cc: Perry Yuan <Perry.Yuan@xxxxxxxx> Cc: Dell.Client.Kernel@xxxxxxxx Cc: platform-driver-x86@xxxxxxxxxxxxxxx Cc: Hans de Goede <hdegoede@xxxxxxxxxx> Cc: Mark Gross <mgross@xxxxxxxxxxxxxxx> --- Found in linux-next, applies to mainline. The last time that I sent a patch to Perry Yuan (about 2 weeks ago), it bounced... drivers/platform/x86/dell/Kconfig | 4 ++++ 1 file changed, 4 insertions(+) --- linux-next-20210927.orig/drivers/platform/x86/dell/Kconfig +++ linux-next-20210927/drivers/platform/x86/dell/Kconfig @@ -164,6 +164,8 @@ config DELL_WMI To compile this driver as a module, choose M here: the module will be called dell-wmi. +if DELL_WMI + config DELL_WMI_PRIVACY bool "Dell WMI Hardware Privacy Support" depends on LEDS_TRIGGER_AUDIO = y || DELL_WMI = LEDS_TRIGGER_AUDIO @@ -198,6 +200,8 @@ config DELL_WMI_LED This adds support for the Latitude 2100 and similar notebooks that have an external LED. +endif # DELL_WMI + config DELL_WMI_SYSMAN tristate "Dell WMI-based Systems management driver" default m
