Hi Hans
On 2021-04-07 06:24, Hans de Goede wrote:
Hi Nicola,
Thank you for your patch series.
I'm not sure what to do with these. I have a couple of concerns here:
1. These features are useful, but not super useful and as such I wonder
how often they are used and this how well tested the firmware is wrt these.
I have added Mark and Nitin from Lenovo to the Cc. Mark, Nitin, can you
comment on if it is ok from a firmware pov to try and use the following
battery related ACPI methods on all thinkpads? :
#define GET_DISCHARGE "BDSG"
#define SET_DISCHARGE "BDSS"
#define GET_INHIBIT "PSSG"
#define SET_INHIBIT "BICS"
I followed up with the firmware team on this - and was told these are
intended to be internal only methods. They are not something the FW team
expected to support or to be used by customers. From a Lenovo point of
view these are not recommended and not supported APIs. Not sure where
you got the API details from but they probably shouldn't have been
disclosed :)
Obviously not our call if they get included or not, however they should
come with a big flag that says "Don't use these unless you know what you
are doing". Our recommendation is not to include them.
Do let me know if there are some important use cases for these so I can
go back to the FW team and discuss supporting them properly.
Mark
