Re: [PATCH v6] platform/x86: Add driver for ACPI WMAA EC-based backlight control

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 21 September 2021 15:53:29 Hans de Goede wrote:
> Hi,
> 
> On 9/20/21 3:51 PM, Pali Rohár wrote:
> > It looks like that no vendor driver starts with "wmi-" prefix. "-wmi"
> > string is used as a suffix. So for consistency it would be better to
> > choose "nvidia-backlight-wmi.ko".
> 
> Right, I should have checked first.
> 
> So I just checked and the standard pattern used is:
> vendor_wmi_feature
> 
> So lets go with nvidia_wmi_backlight.ko

Just source code filenames use hyphen (-) not underscore (_).

> Daniel, can you prepare a patch on top of your merged patch to do
> the rename of the Kconfig entry and the module-name please?
> 
> Regards,
> 
> Hans
> 



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux