Re: [RFC PATCH v1 13/30] platform/x86: wmi: use dynamic debug to print data about events

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi


2021. szeptember 13., hétfő 11:43 keltezéssel, Hans de Goede írta:
> > -	if (debug_event)
> > -		pr_info("DEBUG Event GUID: %pUL\n", wblock->gblock.guid);
> > +	dev_dbg(&wblock->dev.dev, "event 0x%02X\n", event);
>
> The debug_event value gets set by a module-parameter and several WMI related
> howto-s and forum threads on the web refer to this. At one point in time even:
> https://wiki.ubuntu.com/Hotkeys/Troubleshooting
>
> Used to refer to this, but they seem to have dropped this.
>
> Either way this changes makes users have to also deal with dyndbg stuff to
> get the same info which before they could get with just the debug_event module
> param, which makes debugging harder, so I'm going to drop this patch from the
> series.

Would you consider accepting a patch that changes it to:

  if (debug_event)
    dev_info(&wblock->dev.dev, "event 0x%02X\n", event);

?


Regards,
Barnabás Pőcze




[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux