Re: [PATCH v3 0/8] Implement generic cc_platform_has() helper function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 09.09.21 00:58, Tom Lendacky wrote:
This patch series provides a generic helper function, cc_platform_has(),
to replace the sme_active(), sev_active(), sev_es_active() and
mem_encrypt_active() functions.

It is expected that as new confidential computing technologies are
added to the kernel, they can all be covered by a single function call
instead of a collection of specific function calls all called from the
same locations.

The powerpc and s390 patches have been compile tested only. Can the
folks copied on this series verify that nothing breaks for them.

Is there a tree somewhere?

 Also,
a new file, arch/powerpc/platforms/pseries/cc_platform.c, has been
created for powerpc to hold the out of line function.

Cc: Andi Kleen <ak@xxxxxxxxxxxxxxx>
Cc: Andy Lutomirski <luto@xxxxxxxxxx>
Cc: Ard Biesheuvel <ardb@xxxxxxxxxx>
Cc: Baoquan He <bhe@xxxxxxxxxx>
Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
Cc: Borislav Petkov <bp@xxxxxxxxx>
Cc: Christian Borntraeger <borntraeger@xxxxxxxxxx>
Cc: Daniel Vetter <daniel@xxxxxxxx>
Cc: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
Cc: Dave Young <dyoung@xxxxxxxxxx>
Cc: David Airlie <airlied@xxxxxxxx>
Cc: Heiko Carstens <hca@xxxxxxxxxxxxx>
Cc: Ingo Molnar <mingo@xxxxxxxxxx>
Cc: Joerg Roedel <joro@xxxxxxxxxx>
Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
Cc: Maxime Ripard <mripard@xxxxxxxxxx>
Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
Cc: Paul Mackerras <paulus@xxxxxxxxx>
Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Cc: Thomas Zimmermann <tzimmermann@xxxxxxx>
Cc: Vasily Gorbik <gor@xxxxxxxxxxxxx>
Cc: VMware Graphics <linux-graphics-maintainer@xxxxxxxxxx>
Cc: Will Deacon <will@xxxxxxxxxx>
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>

---

Patches based on:
   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
   4b93c544e90e ("thunderbolt: test: split up test cases in tb_test_credit_alloc_all")

Changes since v2:
- Changed the name from prot_guest_has() to cc_platform_has()
- Took the cc_platform_has() function out of line. Created two new files,
   cc_platform.c, in both x86 and ppc to implment the function. As a
   result, also changed the attribute defines into enums.
- Removed any received Reviewed-by's and Acked-by's given changes in this
   version.
- Added removal of new instances of mem_encrypt_active() usage in powerpc
   arch.
- Based on latest Linux tree to pick up powerpc changes related to the
   mem_encrypt_active() function.

Changes since v1:
- Moved some arch ioremap functions within #ifdef CONFIG_AMD_MEM_ENCRYPT
   in prep for use of prot_guest_has() by TDX.
- Added type includes to the the protected_guest.h header file to prevent
   build errors outside of x86.
- Made amd_prot_guest_has() EXPORT_SYMBOL_GPL
- Used amd_prot_guest_has() in place of checking sme_me_mask in the
   arch/x86/mm/mem_encrypt.c file.

Tom Lendacky (8):
   x86/ioremap: Selectively build arch override encryption functions
   mm: Introduce a function to check for confidential computing features
   x86/sev: Add an x86 version of cc_platform_has()
   powerpc/pseries/svm: Add a powerpc version of cc_platform_has()
   x86/sme: Replace occurrences of sme_active() with cc_platform_has()
   x86/sev: Replace occurrences of sev_active() with cc_platform_has()
   x86/sev: Replace occurrences of sev_es_active() with cc_platform_has()
   treewide: Replace the use of mem_encrypt_active() with
     cc_platform_has()

  arch/Kconfig                                 |  3 +
  arch/powerpc/include/asm/mem_encrypt.h       |  5 --
  arch/powerpc/platforms/pseries/Kconfig       |  1 +
  arch/powerpc/platforms/pseries/Makefile      |  2 +
  arch/powerpc/platforms/pseries/cc_platform.c | 26 ++++++
  arch/powerpc/platforms/pseries/svm.c         |  5 +-
  arch/s390/include/asm/mem_encrypt.h          |  2 -
  arch/x86/Kconfig                             |  1 +
  arch/x86/include/asm/io.h                    |  8 ++
  arch/x86/include/asm/kexec.h                 |  2 +-
  arch/x86/include/asm/mem_encrypt.h           | 14 +---
  arch/x86/kernel/Makefile                     |  3 +
  arch/x86/kernel/cc_platform.c                | 21 +++++
  arch/x86/kernel/crash_dump_64.c              |  4 +-
  arch/x86/kernel/head64.c                     |  4 +-
  arch/x86/kernel/kvm.c                        |  3 +-
  arch/x86/kernel/kvmclock.c                   |  4 +-
  arch/x86/kernel/machine_kexec_64.c           | 19 +++--
  arch/x86/kernel/pci-swiotlb.c                |  9 +-
  arch/x86/kernel/relocate_kernel_64.S         |  2 +-
  arch/x86/kernel/sev.c                        |  6 +-
  arch/x86/kvm/svm/svm.c                       |  3 +-
  arch/x86/mm/ioremap.c                        | 18 ++--
  arch/x86/mm/mem_encrypt.c                    | 57 +++++++------
  arch/x86/mm/mem_encrypt_identity.c           |  3 +-
  arch/x86/mm/pat/set_memory.c                 |  3 +-
  arch/x86/platform/efi/efi_64.c               |  9 +-
  arch/x86/realmode/init.c                     |  8 +-
  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c      |  4 +-
  drivers/gpu/drm/drm_cache.c                  |  4 +-
  drivers/gpu/drm/vmwgfx/vmwgfx_drv.c          |  4 +-
  drivers/gpu/drm/vmwgfx/vmwgfx_msg.c          |  6 +-
  drivers/iommu/amd/init.c                     |  7 +-
  drivers/iommu/amd/iommu.c                    |  3 +-
  drivers/iommu/amd/iommu_v2.c                 |  3 +-
  drivers/iommu/iommu.c                        |  3 +-
  fs/proc/vmcore.c                             |  6 +-
  include/linux/cc_platform.h                  | 88 ++++++++++++++++++++
  include/linux/mem_encrypt.h                  |  4 -
  kernel/dma/swiotlb.c                         |  4 +-
  40 files changed, 267 insertions(+), 114 deletions(-)
  create mode 100644 arch/powerpc/platforms/pseries/cc_platform.c
  create mode 100644 arch/x86/kernel/cc_platform.c
  create mode 100644 include/linux/cc_platform.h


base-commit: 4b93c544e90e2b28326182d31ee008eb80e02074




[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux