Hi, On 8/23/21 9:32 AM, Andy Shevchenko wrote: > On Fri, Aug 20, 2021 at 08:18:17PM +0200, Hans de Goede wrote: >> On 8/20/21 1:04 PM, Andy Shevchenko wrote: >>> Move Intel Atom PMC driver to intel sub-directory to improve readability. >>> >>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> >> >> This means that pmc_atom will now not be build if X86_PLATFORM_DRIVERS_INTEL >> is not set (and PCI is enabled). Which will cause missing pmc_atom_read/_write >> symbols in drivers/acpi/acpi_lpss.c. So I have dropped this patch from the >> set, while applying the rest. >> >> Note I'm thinking that we should just remove the whole X86_PLATFORM_DRIVERS_INTEL >> Kconfig option and in the drivers/platform/x86/Makefile replace: >> >> obj-$(CONFIG_X86_PLATFORM_DRIVERS_INTEL) += intel/ >> >> with: >> >> obj-y += intel/ >> >> This will also allows us to fix the scu issue without needing any >> changes to drivers/mfd/Kconfig . >> >> But this can all wait for the 2nd round of renames after 5.15-rc1. >> >> For now I'm moving forward with this v5 series, except with this >> patch dropped. > > Indeed. Thanks for the analysis. > > Btw, should we convert Dell subdir to something similar in terms of Kconfig? I'm not sure, if someone is trying to build a minimal kernel then being able to say 'N' once for all the Dell drivers make sense. OTOH even someone building a minimal (x86) config very likely still needs some of the Intel drivers. So I think we should just keep the Dell bits as is. Regards, Hans >
