Re: [PATCH 00/20] Move Intel platform drivers to intel directory to improve readability.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/10/21 10:03 AM, David E. Box wrote:
Hi,

On Tue, 2021-08-10 at 17:58 +0800, Kate Hsuan wrote:
All the intel platform specific drivers are moved to intel/.
It makes more clear file structure to improve the readability.


A lot of subfolders for single files. Is this necessary? I'm submitting
a single driver soon, unrelated to anything else. I was just going to
drop it in /intel.


Ugh, surely not necessary. Not even desirable IMO.

Thanks for bringing that up.


Kate Hsuan (20):
   Move Intel hid of pdx86 to intel directory to improve readability.
   Move Intel WMI driver of pdx86 to intel/ directory to improve
     readability.
   Move Intel bxtwc driver of pdx86 to intel/ directory to improve
     readability.
   Move Intel chtdc_ti driver of pdx86 to improve readability.
   Move MRFLD power button driver of pdx86 to intel directory to
improve
     readability.
   Move Intel PMC core of pdx86 to intel/ directory to improve
     readability.
   Move Intel PMT driver of pdx86 to intel/ to improve readability.
   Move Intel P-Unit of pdx86 to intel/ directory to improve
readability.
   Move Intel SCU IPC of pdx86 to intel directory to increase
     readability.
   Move Intel SoC telemetry driver to intel directory to improve
     readability.
   Move Intel IPS driver of pdx86 to improve readability.
   Move Intel RST driver of pdx86 to intel directory to improve
     readability.
   Move Intel smartconnect driver of pdx86 to intel/ directory to
improve
     readability.
   Move Intel SST driver to intel/ directory to improve readability.
   Move Intel turbo max 3 driver to intel/ directory to improve
     readability.
   Move Intel uncore freq driver to intel/ directory to improve
     readability.
   Move Intel int0002 vgpio driver to intel/ directory to inprove
     readability.
   Move Intel thermal driver for menlow platform driver to intel/
     directory to improve readability.
   Move OakTrail driver to the intel/ directory to improve
readability.
   Move Intel virtual botton driver to intel/ directory to improve
     readability.

  drivers/platform/x86/Kconfig                  | 297 ----------------
--
  drivers/platform/x86/Makefile                 |  34 +-
  drivers/platform/x86/intel/Kconfig            |  21 ++
  drivers/platform/x86/intel/Makefile           |  31 ++
  drivers/platform/x86/intel/bxtwc/Kconfig      |  15 +
  drivers/platform/x86/intel/bxtwc/Makefile     |   6 +
  .../x86/{ => intel/bxtwc}/intel_bxtwc_tmu.c   |   0
  drivers/platform/x86/intel/chtdc_ti/Kconfig   |  16 +
  drivers/platform/x86/intel/chtdc_ti/Makefile  |   7 +
  .../chtdc_ti}/intel_chtdc_ti_pwrbtn.c         |   0
  drivers/platform/x86/intel/hid/Kconfig        |  17 +
  drivers/platform/x86/intel/hid/Makefile       |   7 +
  .../platform/x86/{ => intel/hid}/intel-hid.c  |   0
  drivers/platform/x86/intel/int0002/Kconfig    |  23 ++
  drivers/platform/x86/intel/int0002/Makefile   |   6 +
  .../{ => intel/int0002}/intel_int0002_vgpio.c |   0
  .../{ => intel}/intel_speed_select_if/Kconfig |   0
  .../intel_speed_select_if/Makefile            |   0
  .../intel_speed_select_if/isst_if_common.c    |   0
  .../intel_speed_select_if/isst_if_common.h    |   0
  .../intel_speed_select_if/isst_if_mbox_msr.c  |   0
  .../intel_speed_select_if/isst_if_mbox_pci.c  |   0
  .../intel_speed_select_if/isst_if_mmio.c      |   0
  drivers/platform/x86/intel/ips/Kconfig        |  14 +
  drivers/platform/x86/intel/ips/Makefile       |   6 +
  .../platform/x86/{ => intel/ips}/intel_ips.c  |   0
  .../platform/x86/{ => intel/ips}/intel_ips.h  |   0
  drivers/platform/x86/intel/menlow/Kconfig     |  14 +
  drivers/platform/x86/intel/menlow/Makefile    |   6 +
  .../x86/{ => intel/menlow}/intel_menlow.c     |   0
  drivers/platform/x86/intel/mrfld/Kconfig      |  17 +
  drivers/platform/x86/intel/mrfld/Makefile     |   6 +
  .../{ => intel/mrfld}/intel_mrfld_pwrbtn.c    |   0
  drivers/platform/x86/intel/oaktrail/Kconfig   |  15 +
  drivers/platform/x86/intel/oaktrail/Makefile  |   6 +
  .../x86/{ => intel/oaktrail}/intel_oaktrail.c |   0
  drivers/platform/x86/intel/pmc_core/Kconfig   |  26 ++
  drivers/platform/x86/intel/pmc_core/Makefile  |   6 +
  .../x86/{ => intel/pmc_core}/intel_pmc_core.c |   0
  .../x86/{ => intel/pmc_core}/intel_pmc_core.h |   0
  .../pmc_core}/intel_pmc_core_pltdrv.c         |   0
  drivers/platform/x86/intel/pmt/Kconfig        |  41 +++
  drivers/platform/x86/intel/pmt/Makefile       |   9 +
  .../x86/{ => intel/pmt}/intel_pmt_class.c     |   0
  .../x86/{ => intel/pmt}/intel_pmt_class.h     |   0
  .../x86/{ => intel/pmt}/intel_pmt_crashlog.c  |   0
  .../x86/{ => intel/pmt}/intel_pmt_telemetry.c |   0
  drivers/platform/x86/intel/punit/Kconfig      |  10 +
  drivers/platform/x86/intel/punit/Makefile     |   6 +
  .../x86/{ => intel/punit}/intel_punit_ipc.c   |   0
  drivers/platform/x86/intel/rst/Kconfig        |  16 +
  drivers/platform/x86/intel/rst/Makefile       |   6 +
  .../platform/x86/{ => intel/rst}/intel-rst.c  |   0
  drivers/platform/x86/intel/scu/Kconfig        |  52 +++
  drivers/platform/x86/intel/scu/Makefile       |  11 +
  .../x86/{ => intel/scu}/intel_scu_ipc.c       |   0
  .../x86/{ => intel/scu}/intel_scu_ipcutil.c   |   0
  .../x86/{ => intel/scu}/intel_scu_pcidrv.c    |   0
  .../x86/{ => intel/scu}/intel_scu_pltdrv.c    |   0
  .../x86/{ => intel/scu}/intel_scu_wdt.c       |   0
  .../platform/x86/intel/smartconnect/Kconfig   |  18 ++
  .../platform/x86/intel/smartconnect/Makefile  |   6 +
  .../smartconnect}/intel-smartconnect.c        |   0
  drivers/platform/x86/intel/telemetry/Kconfig  |  16 +
  drivers/platform/x86/intel/telemetry/Makefile |   9 +
  .../telemetry}/intel_telemetry_core.c         |   0
  .../telemetry}/intel_telemetry_debugfs.c      |   0
  .../telemetry}/intel_telemetry_pltdrv.c       |   0
  .../platform/x86/intel/turbo_max_3/Kconfig    |  14 +
  .../platform/x86/intel/turbo_max_3/Makefile   |   6 +
  .../turbo_max_3}/intel_turbo_max_3.c          |   0
  .../platform/x86/intel/uncore_freq/Kconfig    |  15 +
  .../platform/x86/intel/uncore_freq/Makefile   |   6 +
  .../uncore_freq}/intel-uncore-frequency.c     |   0
  drivers/platform/x86/intel/vbtn/Kconfig       |  16 +
  drivers/platform/x86/intel/vbtn/Makefile      |   6 +
  .../x86/{ => intel/vbtn}/intel-vbtn.c         |   0
  drivers/platform/x86/intel/wmi/Kconfig        |  26 ++
  drivers/platform/x86/intel/wmi/Makefile       |   7 +
  .../{ => intel/wmi}/intel-wmi-sbl-fw-update.c |   0
  .../{ => intel/wmi}/intel-wmi-thunderbolt.c   |   0
  81 files changed, 562 insertions(+), 330 deletions(-)
  create mode 100644 drivers/platform/x86/intel/bxtwc/Kconfig
  create mode 100644 drivers/platform/x86/intel/bxtwc/Makefile
  rename drivers/platform/x86/{ => intel/bxtwc}/intel_bxtwc_tmu.c
(100%)
  create mode 100644 drivers/platform/x86/intel/chtdc_ti/Kconfig
  create mode 100644 drivers/platform/x86/intel/chtdc_ti/Makefile
  rename drivers/platform/x86/{ =>
intel/chtdc_ti}/intel_chtdc_ti_pwrbtn.c (100%)
  create mode 100644 drivers/platform/x86/intel/hid/Kconfig
  create mode 100644 drivers/platform/x86/intel/hid/Makefile
  rename drivers/platform/x86/{ => intel/hid}/intel-hid.c (100%)
  create mode 100644 drivers/platform/x86/intel/int0002/Kconfig
  create mode 100644 drivers/platform/x86/intel/int0002/Makefile
  rename drivers/platform/x86/{ =>
intel/int0002}/intel_int0002_vgpio.c (100%)
  rename drivers/platform/x86/{ =>
intel}/intel_speed_select_if/Kconfig (100%)
  rename drivers/platform/x86/{ =>
intel}/intel_speed_select_if/Makefile (100%)
  rename drivers/platform/x86/{ =>
intel}/intel_speed_select_if/isst_if_common.c (100%)
  rename drivers/platform/x86/{ =>
intel}/intel_speed_select_if/isst_if_common.h (100%)
  rename drivers/platform/x86/{ =>
intel}/intel_speed_select_if/isst_if_mbox_msr.c (100%)
  rename drivers/platform/x86/{ =>
intel}/intel_speed_select_if/isst_if_mbox_pci.c (100%)
  rename drivers/platform/x86/{ =>
intel}/intel_speed_select_if/isst_if_mmio.c (100%)
  create mode 100644 drivers/platform/x86/intel/ips/Kconfig
  create mode 100644 drivers/platform/x86/intel/ips/Makefile
  rename drivers/platform/x86/{ => intel/ips}/intel_ips.c (100%)
  rename drivers/platform/x86/{ => intel/ips}/intel_ips.h (100%)
  create mode 100644 drivers/platform/x86/intel/menlow/Kconfig
  create mode 100644 drivers/platform/x86/intel/menlow/Makefile
  rename drivers/platform/x86/{ => intel/menlow}/intel_menlow.c (100%)
  create mode 100644 drivers/platform/x86/intel/mrfld/Kconfig
  create mode 100644 drivers/platform/x86/intel/mrfld/Makefile
  rename drivers/platform/x86/{ => intel/mrfld}/intel_mrfld_pwrbtn.c
(100%)
  create mode 100644 drivers/platform/x86/intel/oaktrail/Kconfig
  create mode 100644 drivers/platform/x86/intel/oaktrail/Makefile
  rename drivers/platform/x86/{ => intel/oaktrail}/intel_oaktrail.c
(100%)
  create mode 100644 drivers/platform/x86/intel/pmc_core/Kconfig
  create mode 100644 drivers/platform/x86/intel/pmc_core/Makefile
  rename drivers/platform/x86/{ => intel/pmc_core}/intel_pmc_core.c
(100%)
  rename drivers/platform/x86/{ => intel/pmc_core}/intel_pmc_core.h
(100%)
  rename drivers/platform/x86/{ =>
intel/pmc_core}/intel_pmc_core_pltdrv.c (100%)
  create mode 100644 drivers/platform/x86/intel/pmt/Kconfig
  create mode 100644 drivers/platform/x86/intel/pmt/Makefile
  rename drivers/platform/x86/{ => intel/pmt}/intel_pmt_class.c (100%)
  rename drivers/platform/x86/{ => intel/pmt}/intel_pmt_class.h (100%)
  rename drivers/platform/x86/{ => intel/pmt}/intel_pmt_crashlog.c
(100%)
  rename drivers/platform/x86/{ => intel/pmt}/intel_pmt_telemetry.c
(100%)
  create mode 100644 drivers/platform/x86/intel/punit/Kconfig
  create mode 100644 drivers/platform/x86/intel/punit/Makefile
  rename drivers/platform/x86/{ => intel/punit}/intel_punit_ipc.c
(100%)
  create mode 100644 drivers/platform/x86/intel/rst/Kconfig
  create mode 100644 drivers/platform/x86/intel/rst/Makefile
  rename drivers/platform/x86/{ => intel/rst}/intel-rst.c (100%)
  create mode 100644 drivers/platform/x86/intel/scu/Kconfig
  create mode 100644 drivers/platform/x86/intel/scu/Makefile
  rename drivers/platform/x86/{ => intel/scu}/intel_scu_ipc.c (100%)
  rename drivers/platform/x86/{ => intel/scu}/intel_scu_ipcutil.c
(100%)
  rename drivers/platform/x86/{ => intel/scu}/intel_scu_pcidrv.c
(100%)
  rename drivers/platform/x86/{ => intel/scu}/intel_scu_pltdrv.c
(100%)
  rename drivers/platform/x86/{ => intel/scu}/intel_scu_wdt.c (100%)
  create mode 100644 drivers/platform/x86/intel/smartconnect/Kconfig
  create mode 100644 drivers/platform/x86/intel/smartconnect/Makefile
  rename drivers/platform/x86/{ => intel/smartconnect}/intel-
smartconnect.c (100%)
  create mode 100644 drivers/platform/x86/intel/telemetry/Kconfig
  create mode 100644 drivers/platform/x86/intel/telemetry/Makefile
  rename drivers/platform/x86/{ =>
intel/telemetry}/intel_telemetry_core.c (100%)
  rename drivers/platform/x86/{ =>
intel/telemetry}/intel_telemetry_debugfs.c (100%)
  rename drivers/platform/x86/{ =>
intel/telemetry}/intel_telemetry_pltdrv.c (100%)
  create mode 100644 drivers/platform/x86/intel/turbo_max_3/Kconfig
  create mode 100644 drivers/platform/x86/intel/turbo_max_3/Makefile
  rename drivers/platform/x86/{ =>
intel/turbo_max_3}/intel_turbo_max_3.c (100%)
  create mode 100644 drivers/platform/x86/intel/uncore_freq/Kconfig
  create mode 100644 drivers/platform/x86/intel/uncore_freq/Makefile
  rename drivers/platform/x86/{ => intel/uncore_freq}/intel-uncore-
frequency.c (100%)
  create mode 100644 drivers/platform/x86/intel/vbtn/Kconfig
  create mode 100644 drivers/platform/x86/intel/vbtn/Makefile
  rename drivers/platform/x86/{ => intel/vbtn}/intel-vbtn.c (100%)
  create mode 100644 drivers/platform/x86/intel/wmi/Kconfig
  create mode 100644 drivers/platform/x86/intel/wmi/Makefile
  rename drivers/platform/x86/{ => intel/wmi}/intel-wmi-sbl-fw-
update.c (100%)
  rename drivers/platform/x86/{ => intel/wmi}/intel-wmi-thunderbolt.c
(100%)





--
~Randy
Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
https://people.kernel.org/tglx/notes-about-netiquette



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux