Hi Mika, Thanks for your suggestion. I'll add them to the patches and resend them again. Thank you. BR, Kate Kate Hsuan PhD Senior Software Engineer Red Hat APAC Rm. 2708, 27F., No.9, Songgao Rd., Xinyi Dist., Taipei City 110 kate.hsuan@xxxxxxxxxx M: +886-919560388 On Tue, Aug 10, 2021 at 6:06 PM Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> wrote: > > Hi, > > No objections, I think this is good idea but.. > > On Tue, Aug 10, 2021 at 05:58:21PM +0800, Kate Hsuan wrote: > > .. I suggest to add proper commit message here. Many maintainers ignore > patches that don't have one. > > > Signed-off-by: Kate Hsuan <hpa@xxxxxxxxxx> > > --- > > drivers/platform/x86/Kconfig | 47 ----------------- > > drivers/platform/x86/Makefile | 6 +-- > > drivers/platform/x86/intel/Kconfig | 1 + > > drivers/platform/x86/intel/Makefile | 5 ++ > > drivers/platform/x86/intel/scu/Kconfig | 52 +++++++++++++++++++ > > drivers/platform/x86/intel/scu/Makefile | 11 ++++ > > .../x86/{ => intel/scu}/intel_scu_ipc.c | 0 > > .../x86/{ => intel/scu}/intel_scu_ipcutil.c | 0 > > .../x86/{ => intel/scu}/intel_scu_pcidrv.c | 0 > > .../x86/{ => intel/scu}/intel_scu_pltdrv.c | 0 > > .../x86/{ => intel/scu}/intel_scu_wdt.c | 0 > > 11 files changed, 70 insertions(+), 52 deletions(-) > > create mode 100644 drivers/platform/x86/intel/scu/Kconfig > > create mode 100644 drivers/platform/x86/intel/scu/Makefile > > rename drivers/platform/x86/{ => intel/scu}/intel_scu_ipc.c (100%) > > rename drivers/platform/x86/{ => intel/scu}/intel_scu_ipcutil.c (100%) > > rename drivers/platform/x86/{ => intel/scu}/intel_scu_pcidrv.c (100%) > > rename drivers/platform/x86/{ => intel/scu}/intel_scu_pltdrv.c (100%) > > rename drivers/platform/x86/{ => intel/scu}/intel_scu_wdt.c (100%) >