Re: [PATCH v1 1/1] platform/surface: aggregator: Ouse y instead of objs in Makefile

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 03, 2021 at 08:40:10PM +0200, Maximilian Luz wrote:
> On 8/3/21 7:50 PM, Andy Shevchenko wrote:
> > The 'objs' is for user space tools, for the kernel modules
> > we should use 'y'.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> 
> Thank you! I was previously not aware of that distinction. Two small
> notes:
> 
>  - There is a typo in the subject line.
>  - With that change, the ifeq could be placed in-line (see note below).

Will address both.

> All in all looks good to me (assuming the typo gets fixed).
> 
> Reviewed-by: Maximilian Luz <luzmaximilian@xxxxxxxxx>

Thanks!

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux