On Sat, Jul 31, 2021 at 9:10 AM Gayatri Kammela <gayatri.kammela@xxxxxxxxx> wrote: > > As part of collecting Intel x86 specific drivers in their own > folder, move intel_pmc_core* files to its own subfolder there. ... > .../pmc/pltdrv.c} | 0 I would go further and spell it as platform.c. ... > -F: drivers/platform/x86/intel_pmc_core* > +F: drivers/platform/x86/intel/pmc/core* This seems incorrect. ... > + Supported features: > + - SLP_S0_RESIDENCY counter > + - PCH IP Power Gating status > + - LTR Ignore / LTR Show > + - MPHY/PLL gating status (Sunrisepoint PCH only) > + - SLPS0 Debug registers (Cannonlake/Icelake PCH) > + - Low Power Mode registers (Tigerlake and beyond) Perhaps you may use the opportunity to spell codenames in a better way, i.e. Sunrise Point Cannon Lake Ice Lake Tiger Lake as it's done almost everywhere else in the kernel. ... > +obj-$(CONFIG_INTEL_PMC_CORE) += intel_pmc_core.o > +intel_pmc_core-objs += core.o objs suffix is not for kernel modules. Moreover, := has a difference to +=. Why is the latter in use? > +obj-$(CONFIG_INTEL_PMC_CORE) += pltdrv.o This will have the very same issue as with the core module. On top of that, do you need a separate module for it? If so, why? -- With Best Regards, Andy Shevchenko
