Hi, On 7/7/21 4:16 PM, Mario Limonciello wrote: > Right now the driver will still return success even if the OS_HINT > command failed to send to the SMU. In the rare event of a failure, > the suspend should really be aborted here so that relevant logs > can may be captured. > > Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx> > Acked-by: Shyam Sundar S K <Shyam-sundar.S-k@xxxxxxx> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans I will also apply this to the fixes branch and include it in my upcoming v5.14 pdx86 fixes pull-req to Linus. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/amd-pmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/amd-pmc.c b/drivers/platform/x86/amd-pmc.c > index d2f9a62e1166..680f94c7e075 100644 > --- a/drivers/platform/x86/amd-pmc.c > +++ b/drivers/platform/x86/amd-pmc.c > @@ -353,7 +353,7 @@ static int __maybe_unused amd_pmc_suspend(struct device *dev) > if (rc) > dev_err(pdev->dev, "suspend failed\n"); > > - return 0; > + return rc; > } > > static int __maybe_unused amd_pmc_resume(struct device *dev) >
