On 7/8/21 7:04 PM, Dan Williams wrote:
Ok, not my first choice for how to handle the allocation side of that, but not broken. I'd still feel better if there was an actual data structure assigned to file->private_data rather than using that 'void *' pointer directly and casting throughout the driver.
We can add a data structure if we have more member requirements. Currently we only need to pass the memory pointer. But after moving memory allocation to init code (even for vmap), we may not need to use this private pointer. -- Sathyanarayanan Kuppuswamy Linux Kernel Developer
