Re: [PATCH V2 1/1] [x86]: BIOS Dynamic SAR driver for Intel M.2 Modem

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 28.06.21 17:12, Hans de Goede wrote:

Hi,

I'm not in favor of internal reviews, esp. not when new userspace
API is involved. I would greatly prefer for the discussions surrounding
this to be kept public.

ACK. Please do that in open public. There're still lots of things to
discuss that should be discussed in wide public, instead of comittee
behind closed doors.

I agree that ideally we should have some generic userspace API for this,
but I'm afraid that ATM that simply is not possible.

Why not ? Lets collect the actual requirements and talk about some
viable solutions (I've already got a few ideas ...)

This whole notion of maximum tx power being controlled based on various sensors because of SAR reasons is pretty new (at least in the PC/laptop space) and I know of a couple of vendors who are slapping some adhoc firmware
interface on the sensor readings for some modem related userspace
process to consume.

We should bring them here onboard, public discussion. And at the same
time we should make it crystally clear to them that weird adhoc hacks
won't be accepted and just give them very bad reputation and
shitstorming. Seriously, I believe we should go that route, in order
to prevent even more damage by insane firmware interfaces.

Such stuff really doesn't belong into firmware, at least not the way its
done now. Instead there just should be a clear description of the actual
hardware.

I don't think that it is realistic to try and layer a common userspace
interface over this at this point time. Actually I believe that even
trying to do so is a bad idea at this point in time, since this is
all so new that we are bound to get it badly wrong if we try to
design a common userspace API for this now.

actually, I don't think it should go through userland (except perhaps
a knob for switching it on/off).

I also don't want to wait for this to all crystallize out since that
will likely take years; and we should add support for this under Linux
in a reasonable time-frame. For laptops which ship with Linux
pre-installed it is important that there is feature parity between
Windows and Linux; and support for these new type of modems which need
this "SAR" integration is one of the biggest pain points with this ATM.

I don't think that this should serve as an excuse for slappy and vendor specific solutions, especially when userland is involved.

And if we really do that, then just as some intermediate solution,
and lets put it under staging.


--mtx

--
---
Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert
werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schlüssel zu.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@xxxxxxxxx -- +49-151-27565287



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux