Hi Dan, thanks for the patch
On 25/06/2021 14:01, Dan Carpenter wrote:
> This function returns negative error codes, zero (to indicate that
> everything has been completed successfully) and one (to indicate that
> more resources need to be handled still).
>
> This code prints an uninitialized error message when the function
> returns one which potentially leads to an Oops.
Ah! In the default case of the switch, took me a while to see that.
Thanks very much, good catch.
Reviewed-by: Daniel Scally <djrscally@xxxxxxxxx>
>
> Fixes: 5de691bffe57 ("platform/x86: Add intel_skl_int3472 driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> .../platform/x86/intel/int3472/intel_skl_int3472_discrete.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/intel/int3472/intel_skl_int3472_discrete.c b/drivers/platform/x86/intel/int3472/intel_skl_int3472_discrete.c
> index 17c6fe830765..9fe0a2527e1c 100644
> --- a/drivers/platform/x86/intel/int3472/intel_skl_int3472_discrete.c
> +++ b/drivers/platform/x86/intel/int3472/intel_skl_int3472_discrete.c
> @@ -286,10 +286,10 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares,
> int3472->ngpios++;
> ACPI_FREE(obj);
>
> - if (ret)
> + if (ret < 0)
> return dev_err_probe(int3472->dev, ret, err_msg);
>
> - return 0;
> + return ret;
> }
>
> static int skl_int3472_parse_crs(struct int3472_discrete_device *int3472)
