Hi, On 6/17/21 1:30 PM, Shyam Sundar S K wrote: > Couple of existing issues on the completion codes to SMU > and a newer way to get the s0ix statistics are introduced. > > Also, add acpi ids for current and future revisions of the > pmc controller. > > Shyam Sundar S K (6): > platform/x86: amd-pmc: Fix command completion code > platform/x86: amd-pmc: Fix SMU firmware reporting mechanism > platform/x86: amd-pmc: Add support for logging SMU metrics > platform/x86: amd-pmc: Add support for logging s0ix counters > platform/x86: amd-pmc: Add support for ACPI ID AMDI0006 > platform/x86: amd-pmc: Add new acpi id for future PMC controllers Thanks, other then my remarks on patch 2/6, the rest of the series looks good to me, so you may add my: Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> To patches 1/6 and [3-6]/6 . Regards, Hans