On 2021-05-31 9:56 a.m., Hans de Goede wrote: > Hi, > > On 5/31/21 12:31 AM, Mark Pearson wrote: >> This will be used by the Dell and Lenovo WMI management drivers to >> prevent both drivers being active. >> >> Reported-by: kernel test robot <lkp@xxxxxxxxx> >> Signed-off-by: Mark Pearson <markpearson@xxxxxxxxxx> >> --- >> Changes in v2: >> - This is a new file requested as part of the review of the proposed >> think_lmi.c driver. Labeling as V2 to keep series consistent >> >> Changes in v3: >> - Set default in Kconfig, and removed help text >> - Allow multiple modules to register with module. Change API names to >> better reflect this. >> >> Changes in v4: >> - version bump for consistency in series >> >> Changes in v5: >> - Fix issue reported by kernel test robot. Add header file to includes > > Thanks Mark, > > Unfortunately you squashed the Kconfig and Makefile changes which I made > to v4 when fixing it up during merging into 3/3 instead of having them in > v5 of this patch. Oh - apologies; I tried to be careful and make sure I picked up the fixes you'd made as well. I must have missed them here somehow :( > > No worries, since this was the only problem which I could see I've fixed > this up in my review-hans branch while merging v5 of this series there > (replacing v4). > > I did notice a bit of dead code while reviewing the changes which you > made to 3/3 in response to Andy's review. I'll send a follow-up patch > fixing that. Sounds good. I'm intrigued what I've missed. > > I'll leave this sit in my review-hans branch for a bit to give Andy > a chance to give his Reviewed-by and then I'll push this to for-next. Sounds good. Thank you! Mark
