On Thu, May 27, 2021 at 12:17 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > Hi Mark, Andy, > > So as mentioned in my reply to patch 1/3, overall this looks pretty good. > There are a few very small issues remaining, but they are so small that > I've decided to fix them up and merge this into my review-hans branch > with the issues fixed up. > > I plan to let this sit in review-hans a bit longer then usual to > give you (Mark) a chance to check out the changes and ack them > and to give Andy the time to check if his review remarks were > addressed to his liking. I looked into it again and commented on some stuff, but nothing serious noted, so I think the next version would be ready to go. > I've put remarks inline / below about the 2 things which > I've fixed up in this patch. > > Andy, thank you for your review of this. Your suggestions have > improved this driver, esp. the use of kasprintf has made some > of the functions a lot better. You are welcome! -- With Best Regards, Andy Shevchenko
