Hi, On 5/24/21 8:23 AM, Jiapeng Chong wrote: > Eliminate the follow smatch warning: > > drivers/platform/x86/thinkpad_acpi.c:7942 volume_write() warn: > inconsistent indenting. > > Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx> > Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > Changes in v2: > -For the follow advice: https://lore.kernel.org/patchwork/patch/1434215/ > > drivers/platform/x86/thinkpad_acpi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c > index dd60c93..b7fec1b 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -7938,7 +7938,7 @@ static int volume_write(char *buf) > continue; > } else if (sscanf(cmd, "level %u", &l) == 1 && > l >= 0 && l <= TP_EC_VOLUME_MAX) { > - new_level = l; > + new_level = l; > continue; > } > } >