Hi, On 5/21/21 12:35 PM, Luke Jones wrote: > Oh, thanks Hans. I wasn't sure how a git revert was meant to work and assumed that > whatever git did was fine. > > I am absolutely happy for you to take care of those issues and push ahead. Ok, I've pushed these 2 patches to pdx86/for-next now. Regards, Hans > On Fri, May 21 2021 at 12:24:13 +0200, Hans de Goede <hdegoede@xxxxxxxxxx> wrote: >> Hi Luke, On 4/19/21 9:49 AM, Luke D. Jones wrote: >> >> Revert two commits to allow a patch to acpi/video_detect to correctly set the backlight control as native. Luke D. Jones (2): Revert "platform/x86: asus-nb-wmi: Drop duplicate DMI quirk structures" Revert "platform/x86: asus-nb-wmi: add support for ASUS ROG Zephyrus G14 and G15" >> >> Thank you, since the matching drivers/acpi/video_detect.c have been merged by Rafael, I've added these to my review-hans branch now. But there is one problem, these miss a: Signed-off-by: Luke D. Jones <luke@xxxxxxxxxx <mailto:luke@xxxxxxxxxx>> In their commit message, I assume this was an oversight, so I've added this. If you can let me know if this is ok, then I can push these to for-next. I've also rewritten the commit messages to explain why things are being reverted, see: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans <https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans> Regards, Hans
